-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate bulkInsertQuery & insertQuery to ts #16988
base: main
Are you sure you want to change the base?
Conversation
Due to the The I notice there has been some discussion in #11400, is it worth taking this forward now? |
The current plan was to look into supporting both adapters in v8 when we split dialects from core. So we would have @sequelize/sqlite3 and @sequelize/better-sqlite3 packages. I don't think we'll need to revisit this for v7, we already have enough breaking changes for users. I think for this PR it is fine if we disable bigints for sqlite, with a mention to TryGhost/node-sqlite3#1058 (or the related PR 1501 or related issue 922 which was opened by a former sequelize maintainer) |
Ok, makes sense. |
9791df0
to
4fe4828
Compare
a2c0e18
to
17fa3fd
Compare
There is some common changes between this PR and the update PR. Would you prefer I focused on review this one first, or the other one? A lot of the legacy code I'd like to clean up applies to both PRs |
Focus on #17063. |
Pull Request Checklist
Description Of Change
Migrates
bulkInsertQuery
&insertQuery
to typescript.Also fixes Db2 and SQLite returning options for insert and update (SQLite only) statements.
SQLite has had bigint support disabled which will be a breaking change.
Todos