-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: type pgEnum functions and refactor some tests #17253
base: main
Are you sure you want to change the base?
Conversation
@@ -98,6 +98,8 @@ jobs: | |||
run: yarn lerna run test-unit --scope=@sequelize/postgres | |||
- name: Unit tests (core - sqlite3) | |||
run: yarn lerna run test-unit-sqlite3 --scope=@sequelize/core | |||
- name: Unit tests (sqlite3 package) | |||
run: yarn lerna run test-unit --scope=@sequelize/sqlite3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to add this? since sqlite already represented by
- name: Unit tests (core - sqlite3)
run: yarn lerna run test-unit-sqlite3 --scope=@sequelize/core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They run different tests. The scope @sequelize/sqlite3
runs the tests in packages/sqlite3, while @sequelize/core
runs the tests in packages/core
Description of Changes
I started out with some random refactoring, but ended up typing the pgEnum functions as well. I can split that in a different PR now I see the amount of diff of this PR.
The integration tests on errors are not removed, but copied over to unit tests since they work there as well.