Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #221 #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #221 #226

wants to merge 1 commit into from

Conversation

chebum
Copy link

@chebum chebum commented Aug 4, 2016

Please note one test is changed because I doubt it's correct. This line bothers me:
var expected = { '.': ['Project (LO)/', 'nested/', 'one.js', 'sub/'], };

The problem I see here is that we didn't add sub dir into the watch list. The test adds folders Project (LO) and nested only.

This may have unpleasant side-effects. For example, gaze is used in metalsmith-watch library. Metalsmith is a static website generator written in Node.JS. Common folder structure is

root
src // pages
build // ready website
node_modules

You configure to watch for changes in src folder and gaze also starts monitoring node_modules folder as well. I believe this is not expected behavior, so I fixed the test.

@ghost
Copy link

ghost commented Nov 9, 2016

@chebum Your PR doesn't fix this issue #227 but are located in the same area. Ideas how to fix this? See my reply in that ticket.

@chebum
Copy link
Author

chebum commented Nov 10, 2016

@crazyhuggins excessive watches is what I fixed there:

You configure to watch for changes in src folder and gaze also starts monitoring node_modules folder as well.

@ghost
Copy link

ghost commented Nov 11, 2016

@chebum I see. For seems to be kind a useless module if it watches more then what it should. and @shama seems to be out of radio range or switched off this days
Any idea on how to solve #227 issue?

And monitor node_modules by default is expensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant