Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-email): add bgImage and bgColor props to <Column> #188

Merged
merged 4 commits into from Apr 19, 2024

Conversation

lordelogos
Copy link
Collaborator

Component / Package Name:

Column

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

For maximum client compatibility, it is advised to add the background image and color to the <td> tag

in HTML email, bgcolor is used to set the background color and background is used to set background images on the td tag.

Read more here

The bgColor and bgImage props are just wrappers around bgcolor and background respectively and it shifts the error handling within the library rather than to the end users (@ts-expect-error)

@shellscape shellscape merged commit 2fe4ed3 into main Apr 19, 2024
2 checks passed
@shellscape shellscape deleted the feat/column/bg branch April 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants