-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 2 articles #805
Open
stjepanjurekovic
wants to merge
3
commits into
sorrycc:master
Choose a base branch
from
stjepanjurekovic:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added 2 articles #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Stjepan from Manning here. i thought these two articles might be a good match for your list. Thank you for considering it. Best,
Hi, Stjepan from manning here. I thought these two titles might be a good match for your list. Thank you for considering them. Best,
Hi, Stjepan from Manning here. I thought this title might be a good match for your list. Thank you for considering it. Best,
gokaygurcan
requested changes
May 5, 2022
Comment on lines
+1043
to
+1045
* [The joy of JavaScript](https://www.manning.com/books/the-joy-of-javascript) - The key design concepts for clean, and easy-to-maintain code. | ||
* [Testing JavaScript Applications](https://www.manning.com/books/testing-javascript-applications) - A guide to building a comprehensive and reliable JS application testing suite. | ||
* [D3.js in Action, Third Edition](https://www.manning.com/books/d3js-in-action-third-edition) - A book about D3.js that guides you from simple charts to powerful interactive graphics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's nice to add paid resources here.
Ok. Thanks for letting me know.
Best,
…On Thu, May 5, 2022 at 9:17 AM Gökay Gürcan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In README.md
<#805 (comment)>
:
> +* [The joy of JavaScript](https://www.manning.com/books/the-joy-of-javascript) - The key design concepts for clean, and easy-to-maintain code.
+* [Testing JavaScript Applications](https://www.manning.com/books/testing-javascript-applications) - A guide to building a comprehensive and reliable JS application testing suite.
+* [D3.js in Action, Third Edition](https://www.manning.com/books/d3js-in-action-third-edition) - A book about D3.js that guides you from simple charts to powerful interactive graphics.
I don't think it's nice to add paid resources here.
—
Reply to this email directly, view it on GitHub
<#805 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDIEMLYDJRPO4HMYTF4GNTVINYXNANCNFSM5M22BGSQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Stjepan Jureković
Manning Publications - Marketing
***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Stjepan from Manning here. i thought these two articles might be a good match for your list. Thank you for considering it.
Best,
Checklist:
...