Add internal DAC outputs to available opamp inputs. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by adding internal structs for the DAC outputs and passing these into the constructor functions instead of an input pin, e.g. `opamp1.follower(Dac3Out1, Some(gpioa.pa2.into_analog()));`
usbalbin
reviewed
Feb 21, 2024
|
|
||
| /// Internal output of DAC 4 channel 2. | ||
| pub struct Dac4Out2; | ||
|
|
There was a problem hiding this comment.
We have the channel types from the dac module if we want to use those. I believe that would force the user to pass in the DAC they actually initialized, reducing the risk of error.
There was a problem hiding this comment.
I like the idea but I don't think taking ownership of the DAC channel works in this case, for two reasons:
- The same DAC output can be used as input for multiple opamps (dac3ch1 can go to opamps 1 and 6 simultaneously, verified that this works).
- The user wouldn't be able to set the DAC's value (or other configuration) after setting up the opamp. There's some cases where that's ok (if using DMA) but the easiest setup would become impossible.
There was a problem hiding this comment.
Passing by reference would probably be enough. As long as the OPAMP does not keep the reference, the dac can still be modified and similar which I believe would solve both 1 and 2?
There was a problem hiding this comment.
Something similar is done for the comparator.
Usage looks like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by adding internal structs for the DAC outputs and passing these into the constructor functions instead of an input pin, e.g.
opamp1.follower(Dac3Out1, Some(gpioa.pa2.into_analog()));I've tested that this works at least with opamps 1, 3, 4, and 5 in follower mode on an STM32G473. Can't verify everything of course but I don't see anything obvious that would break elsewhere, and it at least builds for other devices.
After writing this I now see related work in #113. If I'm reading right, I think this change is completely orthogonal and should merge with that one pretty cleanly.