-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to embedded-hal v1.0.0 #476
base: master
Are you sure you want to change the base?
Conversation
I am stuck trying to create a second (non-SYST) delay. Do you have an example of how to do this now? I'm not having any luck with approaches I've used before. (Also, you might remove the example using |
It's not possible until there's another |
@richardeoin could you clarify "not possible until there's another |
Someone would have to add the implementations in this crate. I wouldn't
expect it to be very complicated once you get used to how macros are used
to implement the timers in this crate.
…On Sun, Dec 24, 2023, 4:02 PM pdgilbert ***@***.***> wrote:
@richardeoin <https://github.com/richardeoin> could you clarify "not
possible until there's another DelayNs implementation". Is that another
embedded-hal implementation or an stm32h7xx-hal implementation? I'm
confused because I have non-SYST examples working with stm32f4xx_hal, but
they may be using that hal's magic for dual support of an older
embedded-hal.
—
Reply to this email directly, view it on GitHub
<#476 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUS5FKINSR3YC7CZBKUKM3YLCQ7TAVCNFSM6AAAAABBAAQFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGYYDANRVGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@pdgilbert Indeed I mean that more code needs to be added to this PR. I added a very minimal implementation of |
Ok, thanks @richardeoin. That seems to work to get some of my examples compiling. Now the main problem is device crates using eh-1. For anyone interested, the CI is in the jobs for |
I think there is some worth in supporting both e-h v1.0 and e-h v0.2 traits to avoid dependency hell during the transition (including our own dependencies like |
Use released version ofNot requiredstm32-fmc
(when released)transaction
implementationDelayNs
for Timers. AfterDelayFromCountDownTimer
was removedDelayNs
is only implemented for SysTickdelay_ns
method in theDelayNs
implementation onDelayFromCountDownTimer
DelayFromCountDownTimer