chore(content-releases): releases migration to v5 #20259
Conversation
* chore: migrate bulkDelete to v5 * chore: change findLocales type to accept strings array * fix: docs prettier styles * chore: remove console.log
…into v5/bulk-publish-unpublish
Feranchz
added
pr: chore
Feranchz
requested review from
simotae14,
madhurisandbhor,
remidej,
Marc-Roig and
markkaylor
packages/core/content-releases/server/src/controllers/release.ts
Outdated
Show resolved
Hide resolved
This comment was marked as spam.
This comment was marked as spam.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| await strapi.db.query(RELEASE_ACTION_MODEL_UID).deleteMany({ | ||
| where: { | ||
| target_type: model.uid, | ||
| target_id: { | ||
| $in: (entriesToDelete as Array<{ id: Data.ID }>).map((entry) => entry.id), | ||
| }, | ||
| contentType: model.uid, | ||
| locale: where.locale ?? null, | ||
| ...(where.documentId && { entryDocumentId: where.documentId }), |
There was a problem hiding this comment.
could this create a recursive infinite loop? (deleteMany triggering this same lifecycle)
There was a problem hiding this comment.
It's a good point, honestly never thought about that. But you can see at line 15 that this subscriber is added only for D&P ContentTypes, and ReleaseAction doesn't has D&P, so the subscriber is not registered for it
| const query: GetReleases.Request['query'] = await permissionsManager.sanitizeQuery(ctx.query); | ||
| const { results, pagination } = await releaseService.findPage(query); |
There was a problem hiding this comment.
shoulndt this endpoint also need a yup validation?
There was a problem hiding this comment.
I don't think is necessary because this query doesn't handle any custom logic and the ctx.query is already sanitized with the permissionsManager, I tried some basis cases and it's working
packages/core/content-releases/server/src/middlewares/documents.ts
Outdated
Show resolved
Hide resolved
…ny lifecycle async
What does it do?
Migrates and apply new changes on the Content Releases plugin for v5.
Work to do