Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate forward into forward & fit #167

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

ycq091044
Copy link
Collaborator

@ycq091044 ycq091044 commented Jun 3, 2023

All models (except drug recommendation modules) are affected in this PR.

@ycq091044 ycq091044 requested a review from zlin7 June 18, 2023 04:08
@ycq091044
Copy link
Collaborator Author

I am not sure whether my change will affect your UQ module. Could you please take a look? @zlin7. You may need to change some places from self.model(**kwargs) to self.model.fit(**kwargs).

@ycq091044
Copy link
Collaborator Author

Do you have time to review the PR @zzachw. Also, it would be good if @zlin7 could check whether my split would block your UQ module.

@ycq091044
Copy link
Collaborator Author

I will leave the PR here for now (it is not needed in tutorial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant