Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefer custom backoff strategy to built-in if provided #2277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prefer custom backoff strategy to built-in if provided #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/classes/backoffs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ function lookupStrategy(
backoff: BackoffOptions,
customStrategy?: BackoffStrategy,
): BackoffStrategy {
if (backoff.type in Backoffs.builtinStrategies) {
return Backoffs.builtinStrategies[backoff.type](backoff.delay!);
} else if (customStrategy) {
if (customStrategy) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means that you want to have the possibility to override a builtin strategy? that's the only case that came into my mind, but it would be the same as defining a customFixed strategy or a customExponential one, also probably more people is using the default ones

return customStrategy;
} else if (backoff.type in Backoffs.builtinStrategies) {
return Backoffs.builtinStrategies[backoff.type](backoff.delay!);
} else {
throw new Error(
`Unknown backoff strategy ${backoff.type}.
Expand Down