Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pro): add local group concurrency section #2551

Merged
merged 2 commits into from May 14, 2024

Conversation

roggervalf
Copy link
Collaborator

No description provided.

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, does obliterate remove the keys created by this functionality?

@@ -0,0 +1,13 @@
# Local group concurrency

It is possible to set specific group concurrency. This can be useful if you want to differentiate your groups with different max councurrency rules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also possible to ...

differentiate -> run

I would rewrite as this:
It is also possible to set a specific concurrency value to a given group. This is useful if you require that different groups should run with different concurrency factors.
Please keep in mind that when specifying a group's concurrency factor, you are storing this value in Redis, so it is your responsibility to remove it if you are not using it anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, obliterate method is not removing any groups now, but I'm adding this deletion when removing groups in https://github.com/taskforcesh/bullmq-pro/pull/226

@roggervalf roggervalf merged commit cce0774 into master May 14, 2024
11 checks passed
@roggervalf roggervalf deleted the docs-pro-local-concurrency branch May 14, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants