Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to set API key #2052

Merged
merged 2 commits into from
May 23, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

closes #1997

Add shortcut to add an api key to a connection. Instead of

    WorkflowServiceStubsOptions.Builder stubOptions =
        WorkflowServiceStubsOptions.newBuilder()
             ...
            .addGrpcMetadataProvider(
                new AuthorizationGrpcMetadataProvider(() -> "Bearer " + API_KEY))

Users can now set

    WorkflowServiceStubsOptions.Builder stubOptions =
        WorkflowServiceStubsOptions.newBuilder()
             ...
            .addApiKey(
                () -> API_KEY)

@Quinn-With-Two-Ns
Copy link
Contributor Author

@cretz Is this what you had in mind as a shortcut?

@cretz
Copy link
Member

cretz commented May 10, 2024

Yes, this makes sense to me

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review May 22, 2024 22:32
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 22, 2024 22:32
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 5e5cf0b into temporalio:master May 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API key client option
2 participants