Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAUTH Additional claims #1969

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

serg-bs
Copy link

@serg-bs serg-bs commented Apr 8, 2024

Description & motivation πŸ’­

#1913

Design Considerations 🎨

We introduce new parameter in oauth config

Testing πŸ§ͺ

Tune the Oauth provider to response with additional claims, I did it with SAP IAS
Response example:

    "IDTokenClaims": {
..
        "group": [
            "pgadmin",
            "temporal"
        ]
    }

How was this tested πŸ‘»

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: πŸšΆπŸ½β€β™‚οΈπŸšΆπŸ½β€β™€οΈ

Checklists

Issue(s) closed

#1913

Docs

Any docs updates needed?

In helm chart web-deployment.yaml

         {{- if .Values.web.config.auth.additionalClaims}}
            - name: TEMPORAL_OAUTH_ADDITIONAL_CLAIMS
              value: |
                  {{ printf "%s" .Values.web.config.auth.additionalClaims}}
        {{- end }}

In values.yaml

web:
  image:
    repository: sergbs/temporalui
  config:
    auth:
      enabled: true
      additionalClaims: "group: \"temporal\""

That works on our environment perfect

@serg-bs serg-bs requested a review from a team as a code owner April 8, 2024 11:54
@serg-bs serg-bs requested review from stevekinney and removed request for a team April 8, 2024 11:54
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
holocene βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 15, 2024 9:23am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sergei Bespalov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants