Night mode audit #2118
Merged
Night mode audit #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
force-pushed
the
DT-2137-color-variables-audit
branch
from
9a8e1ec
to
48cf33a
Compare
stevekinney
reviewed
May 17, 2024
| @@ -22,6 +22,6 @@ | |||
|
|
|||
| <style lang="postcss"> | |||
| .frequency { | |||
| @apply flex h-auto max-h-32 flex-col overflow-auto rounded-lg bg-inverse px-2 py-2 font-mono text-sm text-[#e9d5ff]; | |||
| @apply flex h-auto max-h-32 flex-col overflow-auto rounded-lg bg-spaceBlack px-2 py-2 font-mono text-sm text-[#e9d5ff]; | |||
There was a problem hiding this comment.
Should we just make spaceBlack … black?
There was a problem hiding this comment.
I would but we also have this black that we use.
...rkflow/workflows-summary-configurable-table/tests/__snapshots__/table-body-cell.test.ts.snap
Outdated
Show resolved
Hide resolved
rossedfort
reviewed
May 17, 2024
There was a problem hiding this comment.
This is amazing @laurakwhit great work! I have some questions/comments but nothing major
src/lib/components/workflow/workflows-summary-configurable-table/batch-actions.svelte
Outdated
Show resolved
Hide resolved
rossedfort
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Audit of color variables and Holocene components to align with designs.
Screenshots (if applicable) 📸
Workflows
Workflow detail
Timeline
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Components with significant changes to verify look/work as expected:
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2137Docs
Any docs updates needed?