Add Facebook SDK support #850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-lopreiato
requested changes
Mar 6, 2018
There was a problem hiding this comment.
Thanks for adding this, @chrismarra!
Do you mind verifying that you can run a prod build locally? If you need to, you can do exactly what travis does by running ./scripts/travis/travis-worker.sh PROD-BUILD? You'll likely need some proguard tweaks to get everything to compile
|
Absolutely, was submitting half to make sure I did a PR right.
Any other testing steps you recommend? Working on some other changes.
…On Tue, Mar 6, 2018 at 2:45 AM, Phil Lopreiato ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for adding this, @chrismarra <https://github.com/chrismarra>!
Do you mind verifying that you can run a prod build locally? If you need
to, you can do exactly what travis does by running
./scripts/travis/travis-worker.sh PROD-BUILD? You'll likely need some
proguard tweaks to get everything to compile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#850 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXs_vnNhWufw0WRVBRocNguIOkmH3-5ks5tbdwVgaJpZM4SbYTk>
.
|
|
Nothing else, I don't think - as long as a prod apk builds fine we'll be good. This integration will help us better promote the app on FB, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds the Facebook SDK through Gradle and initializes it. Because of some conflicts with our version of the android compatibility library, I added one "exclude group:"com.android.support"" which shouldn't affect functionality.
Issues Reference: n/a
Test Plan: Compiled and ran in emulator running Google Play Services.
Screenshots: n/a