[Do Not Merge] Sign In With Apple #953
Conversation
Added Initial Sign In with Apple. Need to get return user info. Add User Accept Permissions and Apple Dev Account
|
How many Android users do we expect regularly use Apple accounts? |
| @@ -94,7 +94,7 @@ android { | |||
|
|
|||
| defaultConfig { | |||
| applicationId "com.thebluealliance.androidclient" | |||
| minSdkVersion 16 | |||
| minSdkVersion 17 | |||
There was a problem hiding this comment.
@phil-lopreiato any stats on users on API level 16?
Honestly I'd be in favor of going to 21 or 23 soon, but just curious on whether there's any drive to keep it lowerl
There was a problem hiding this comment.
If it is a must we can keep Android 16. I just used a dependency for the Sign In with Apple button so I could test really quickly. If we needed I can make a button just thought this would be easier lol. The dependency needed a minimum of API 17
There was a problem hiding this comment.
I've always just kept it where it was until we had a compelling enough reason to bump it. Bumping to 17 should have practically no effect
android/build.gradle
Outdated
| @@ -215,6 +215,7 @@ repositories { | |||
| maven { | |||
| url "http://github.com/wada811/Android-Material-Design-Colors/raw/master/repository/" | |||
| } | |||
| mavenCentral() | |||
There was a problem hiding this comment.
Were you having issues resolving the new dependency without this? The top level build.gradle already defines mavenCentral() as a repo: https://github.com/the-blue-alliance/the-blue-alliance-android/blob/master/build.gradle#L41
There was a problem hiding this comment.
I did encounter dependency issues so I tried adding a few things and it worked when I added it worked. I'll try again to see if it was just Android Studio acting up.
There was a problem hiding this comment.
Thanks for catching this. It worked, I guess Android Studio was acting up when I ran it.
| # Specifies the JVM arguments used for the daemon process. | ||
| # The setting is particularly useful for tweaking memory settings. | ||
| # Default value: -Xmx10248m -XX:MaxPermSize=256m | ||
| # Default value: -Xmx1024m -XX:MaxPermSize=256m |
There was a problem hiding this comment.
Lol, that was definitely wrong before.
I don't exactly know how much we can expect. However, I came across a couple of articles explaining why we should have it as TBA has an iOS app. It gives people who have an android device to sign in with their own apple id. More and more people are getting apple ids from Android. I am not sure how it will impact us, however, I am seeing more Sign in With Apple on Android Apps. |
|
@bherbst (it doesn’t seem like I can reply inline) re: how many Android users will use Sign In with Apple - the motivation behind this is Apple is requiring us on iOS to support Sign In with Apple, since we offer other social logins. Currently, we can’t push updates to the App Store (we’ve been blocked since April-ish) because we’re not in compliance with this new rule yet. Part of the challenge is we need to enable users to use Sign In with Apple on all of our platforms. So although signing in with an Apple ID will be rare on Android, we need it to ensure if users start their account on web with Sign In with Apple, they can pickup on Android |
|
Ugh, forgot about that requirement for Apple sign-in. Big old 👎 to Apple. |
Added OAuth Scopes and Modified for TbaLogger
arnavs-0
changed the title
Added Initial Sign In with Apple.
Summary:
Added Initial Sign In with Apple. We need to return the user for the profile. Clean up Code, Add Apple Developers to Firebase. We need to add a warning for using user data.
Test Plan:
Still under development. Need to add all features.
Screenshots: