Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove CD from suggestions #3048

Merged
merged 2 commits into from
May 25, 2024

Conversation

jaredhasenklein
Copy link
Contributor

Temporarily removes CD-media is a suggested media type

Description

  • Comments out the language suggesting it (so that we can easily add it back in when we start supporting again)
  • Changes placeholder text on form to be an Imgur URL instead

Motivation and Context

#2361

Next steps

  • Fix 500 errors caused by submitting a previously-valid CD-media URL
  • Start supporting photos from CD again

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change API specifications or require data migrations)

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (24652da) to head (5a1b61e).
Report is 191 commits behind head on py3.

Additional details and impacted files
@@            Coverage Diff             @@
##              py3    #3048      +/-   ##
==========================================
- Coverage   93.10%   92.88%   -0.23%     
==========================================
  Files         658      656       -2     
  Lines       42145    42580     +435     
  Branches       60       60              
==========================================
+ Hits        39241    39551     +310     
- Misses       2896     3021     +125     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fangeugene fangeugene changed the base branch from py3 to master September 27, 2020 19:33
@fangeugene fangeugene changed the base branch from master to py3 September 27, 2020 19:33
@fangeugene
Copy link
Member

Can you reopen this PR but onto master instead of py3? thanks!

@ZachOrr
Copy link
Member

ZachOrr commented Sep 29, 2020

@fangeugene It looks like you properly changed the base for this branch. We should be able to merge, yeah?

@fangeugene
Copy link
Member

fangeugene commented Sep 29, 2020 via email

@ZachOrr
Copy link
Member

ZachOrr commented Sep 29, 2020

Oh lame. Sorry - I got it backwards zz

@fangeugene fangeugene enabled auto-merge (squash) May 25, 2024 06:56
@fangeugene fangeugene disabled auto-merge May 25, 2024 06:57
@fangeugene fangeugene enabled auto-merge (squash) May 25, 2024 06:57
@fangeugene fangeugene merged commit 2c3b72f into the-blue-alliance:py3 May 25, 2024
15 checks passed
github-actions bot added a commit that referenced this pull request May 25, 2024
github-actions bot added a commit that referenced this pull request May 25, 2024
Copy link

Screenshots

Homepage

Homepage

GameDay

GameDay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants