District teams list: only show teams who've competed that year #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdenio
commented
May 26, 2023
| @@ -94,10 +95,13 @@ def __init__(self, district_key: DistrictKey) -> None: | |||
| def _query_async( | |||
| self, district_key: DistrictKey | |||
| ) -> Generator[Any, Any, List[Team]]: | |||
| year = int(re.match(r"\d{4,}", district_key).group(0)) | |||
There was a problem hiding this comment.
I'm assuming there's some sort of helper for parsing these but I couldn't find one.
cjdenio
commented
May 26, 2023
Codecov Report
@@ Coverage Diff @@
## py3 #5289 +/- ##
===========================================
- Coverage 92.25% 71.22% -21.04%
===========================================
Files 640 8 -632
Lines 40277 344 -39933
Branches 60 60
===========================================
- Hits 37159 245 -36914
+ Misses 3110 91 -3019
Partials 8 8 |
fangeugene
reviewed
May 26, 2023
fangeugene
reviewed
May 26, 2023
fangeugene
reviewed
May 26, 2023
There was a problem hiding this comment.
Overall this seems good. Though I wonder if filtering on query is the correct thing to do, or if we should be doing more validation on write?
cc @phil-lopreiato thoughts?
fangeugene
reviewed
May 26, 2023
fangeugene
reviewed
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The district teams list sometimes includes teams that didn't actually compete in a given year. This seems to be an issue with the FIRST API:
This change filters the list by only showing teams that have competed (or will compete) in an event that year.
Motivation and Context
Fixes #5106!
How Has This Been Tested?
I've verified that after this change, the NE team list matches the one on FIRST's website.
Screenshots (if appropriate):
Types of changes