Add Season Endpoint #5414
Open
Add Season Endpoint #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-lopreiato
requested changes
Dec 30, 2023
There was a problem hiding this comment.
Hey! Thanks for the contribution (and sorry for the delay in review...)
I wonder if we should instead import the data from FIRST's API, store it in the TBA database, and make endpoints like /status/season/<year> to return them individually. That way, we don't have to duplicate other parts of /status and can just plumb through whatever FIRST has upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Responding to an issue asking for more information on the season in the status endpoint. This creates a new endpoint called season with the kickoff time in UTC and future data.
Motivation and Context
This adds data from the FRC API to the Blue Alliance API for easier access. #5248
How Has This Been Tested?
Tested in a Flask Server.
Screenshots (if appropriate):
Types of changes