Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add longer cache timeouts to apiv3 #5690

Draft
wants to merge 1 commit into
base: py3
Choose a base branch
from

Conversation

phil-lopreiato
Copy link
Member

This can save some costs by caching data unrelated to the current year (and therefore unlikely to change) for longer than the default 61 seconds.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6baab9c) 93.07% compared to head (046a8c3) 71.22%.
Report is 1 commits behind head on py3.

Additional details and impacted files
@@             Coverage Diff             @@
##              py3    #5690       +/-   ##
===========================================
- Coverage   93.07%   71.22%   -21.86%     
===========================================
  Files         658        8      -650     
  Lines       41937      344    -41593     
  Branches       60       60               
===========================================
- Hits        39032      245    -38787     
+ Misses       2897       91     -2806     
  Partials        8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Screenshots

Homepage

Homepage

GameDay

GameDay

github-actions bot added a commit that referenced this pull request Jan 16, 2024
github-actions bot added a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant