Add 2024 event insights #5768
Draft
Add 2024 event insights #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## py3 #5768 +/- ##
==========================================
- Coverage 93.10% 92.65% -0.46%
==========================================
Files 658 656 -2
Lines 42145 42688 +543
Branches 60 60
==========================================
+ Hits 39241 39554 +313
- Misses 2896 3126 +230
Partials 8 8 ☔ View full report in Codecov by Sentry. |
fangeugene
reviewed
May 25, 2024
| @@ -36,7 +37,7 @@ def calculate_event_insights( | |||
| return None | |||
|
|
|||
| @classmethod | |||
| def calculate_event_insights_2023(cls, matches: List[Match]) -> EventInsights: | |||
| def calculate_event_insights_2024(cls, matches: List[Match]) -> EventInsights: | |||
There was a problem hiding this comment.
Git's diff algorithm is struggling hard here... 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 2024 event insights
Motivation and Context
MOAR DATA
How Has This Been Tested?
Still a WIP, but testing locally.
Screenshots (if appropriate):
Types of changes