Remove team normalized location uses #5837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## py3 #5837 +/- ##
==========================================
+ Coverage 93.10% 93.41% +0.30%
==========================================
Files 658 658
Lines 42145 42268 +123
Branches 60 60
==========================================
+ Hits 39241 39486 +245
+ Misses 2896 2774 -122
Partials 8 8 ☔ View full report in Codecov by Sentry. |
fangeugene
reviewed
Mar 22, 2024
| @@ -207,61 +207,6 @@ def compute_event_location_score( | |||
|
|
|||
| return score | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
Any chance we can keep this but not expose it anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stopped normalizing team locations a while ago. This pull request removes the code that used to call the Google API to normalize team locations.