Cross-compile dev image for arm64 #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## py3 #5899 +/- ##
==========================================
- Coverage 93.10% 92.88% -0.23%
==========================================
Files 658 656 -2
Lines 42145 42580 +435
Branches 60 60
==========================================
+ Hits 39241 39551 +310
- Misses 2896 3021 +125
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
Lemme try to give this a look soon! I'm on an ARM Mac so - I suspect if we pulled the pre-compiled from the repo this would speed up my local instance. Just need to see why the checks are failing. Also cc @phil-lopreiato - I'm not necessarily the domain expert here |
fangeugene
approved these changes
May 25, 2024
ScreenshotsHomepage
GameDay
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the docker image build time by... a fair bit, as it's cross-compiling this from amd64 to arm64. I think this is a fair substitute to make it a bit easier for folks with Mx macs get up and running easier (and also helping me get around some work laptop funkiness with SSL).