Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react, wallets] Add imToken Wallet #2497

Merged
merged 11 commits into from Mar 20, 2024
Merged

[react, wallets] Add imToken Wallet #2497

merged 11 commits into from Mar 20, 2024

Conversation

makoshan
Copy link
Contributor

@makoshan makoshan commented Mar 18, 2024

Problem solved

This PR adds support for the imToken wallet, including wallet IDs, connectors, locales.

Changes made

  • Added imToken wallet support
  • Updated locales for imToken Wallet
  • Implemented ImTokenConnector class for connecting to imToken Wallet
  • Created ImTokenWallet class for imToken wallet integration
  • The following files were skipped due to too many changes: packages/wallets/src/evm/wallets/imtoken-wallet.ts, - packages/react/src/wallet/wallets/imtoken/imtokenWallet.tsx

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:


PR-Codex overview

This PR adds support for the imToken wallet across various files and modules.

Detailed summary

  • Added imTokenWallet to wallets and locales
  • Created ImTokenConnector class
  • Implemented ImTokenWallet class
  • Updated package.json files
  • Modified useInstalledWallets to check for imToken installation

The following files were skipped due to too many changes: packages/wallets/src/evm/wallets/imtoken.ts, packages/react/src/wallet/wallets/imtoken/imTokenWallet.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@makoshan makoshan requested review from a team as code owners March 18, 2024 01:40
Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: abff3ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/react Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jnsdls jnsdls requested a review from MananTank March 18, 2024 19:55
@jnsdls
Copy link
Member

jnsdls commented Mar 18, 2024

thanks for the contribution @makoshan - we'll review!

makoshan and others added 2 commits March 19, 2024 15:43
Co-authored-by: xwartz <stddup@gmail.com>
Signed-off-by: Mako Shan <imakoshan@gmail.com>
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.changeset/tall-moose-add-imToken.md Outdated Show resolved Hide resolved
Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>
@jnsdls jnsdls enabled auto-merge March 20, 2024 17:46
@jnsdls
Copy link
Member

jnsdls commented Mar 20, 2024

thanks! we'll get a release out today!

@jnsdls jnsdls disabled auto-merge March 20, 2024 18:54
@jnsdls jnsdls merged commit 79c9e13 into thirdweb-dev:main Mar 20, 2024
7 of 8 checks passed
@jnsdls jnsdls mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants