EIP-5792 Support #3001

gregfromstl · 2024-05-11T06:29:39Z

PR-Codex overview

This PR focuses on enhancing wallet capabilities and improving random bytes generation.

Detailed summary

Updated randomBytes32 function to accept a length parameter for flexible byte generation.
Added OneOf type utility for handling optional object keys.
Improved wallet capabilities checking for smart and in-app wallets.
Refactored random bytes generation in various ERC token signature functions.

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/erc4337/account/common.ts, pnpm-lock.yaml, packages/thirdweb/src/wallets/wallet-connect/index.ts, packages/thirdweb/src/wallets/eip5792/types.ts, .changeset/eight-planes-design.md, packages/thirdweb/src/wallets/injected/index.ts, packages/thirdweb/src/wallets/eip5792/show-calls-status.test.ts, packages/thirdweb/src/wallets/eip5792/show-calls-status.ts, packages/thirdweb/src/wallets/eip5792/get-calls-status.ts, packages/thirdweb/src/wallets/eip5792/get-capabilities.ts, packages/thirdweb/src/wallets/in-app/core/lib/in-app-wallet-calls.ts, packages/thirdweb/src/wallets/coinbase/coinbaseSDKWallet.ts, packages/thirdweb/src/wallets/eip5792/get-calls-status.test.ts, packages/thirdweb/src/wallets/eip5792/send-calls.ts, packages/thirdweb/src/wallets/eip5792/get-capabilities.test.ts, packages/thirdweb/src/wallets/eip5792/send-calls.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

test(wallets/eip5792)

docs(wallets/eip5792)

linear · 2024-05-11T06:29:42Z

CNCT-1136 Add 5792 Utilities

changeset-bot · 2024-05-11T06:29:43Z

🦋 Changeset detected

Latest commit: b80aaca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Minor
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2024-05-11T06:32:47Z

CodSpeed Performance Report

Merging #3001 will not alter performance

_{Comparing greg/cnct-1136 (b80aaca) with main (cfe60d2)}

Summary

✅ 9 untouched benchmarks

codecov · 2024-05-11T20:48:53Z

Codecov Report

Attention: Patch coverage is 81.63017% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 61.93%. Comparing base (cfe60d2) to head (b80aaca).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
- Coverage   62.38%   61.93%   -0.45%     
==========================================
  Files         751      765      +14     
  Lines       52235    54164    +1929     
  Branches     2968     3039      +71     
==========================================
+ Hits        32588    33549     +961     
- Misses      19146    20112     +966     
- Partials      501      503       +2

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`54.02% <ø> (ø)`		Carriedforward from 7346b9a
packages	`63.73% <81.63%> (-0.64%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...sions/airdrop/write/airdropERC1155WithSignature.ts	`100.00% <100.00%> (ø)`
...ensions/airdrop/write/airdropERC20WithSignature.ts	`100.00% <100.00%> (ø)`
...nsions/airdrop/write/airdropERC721WithSignature.ts	`100.00% <100.00%> (ø)`
...s/thirdweb/src/extensions/erc1155/write/sigMint.ts	`97.60% <100.00%> (ø)`
...ges/thirdweb/src/extensions/erc20/write/sigMint.ts	`95.78% <100.00%> (ø)`
.../thirdweb/src/extensions/erc4337/account/common.ts	`95.12% <100.00%> (ø)`
...es/thirdweb/src/extensions/erc721/write/sigMint.ts	`96.42% <100.00%> (ø)`
...es/thirdweb/src/transaction/prepare-transaction.ts	`100.00% <100.00%> (ø)`
packages/thirdweb/src/utils/uuid.ts	`100.00% <100.00%> (ø)`
packages/thirdweb/src/wallets/create-wallet.ts	`53.55% <100.00%> (+0.80%)`	⬆️
... and 11 more

... and 5 files with indirect coverage changes

github-actions · 2024-05-11T21:12:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	39.08 KB (-0.13% 🔽)	782 ms (-0.13% 🔽)	2.6 s (+28.21% 🔺)	3.4 s
thirdweb (cjs)	88.12 KB (+0.1% 🔺)	1.8 s (+0.1% 🔺)	5.8 s (-1.5% 🔽)	7.5 s
thirdweb (minimal + tree-shaking)	4.73 KB (0%)	95 ms (0%)	320 ms (-45.01% 🔽)	415 ms
thirdweb/chains (tree-shaking)	400 B (0%)	10 ms (0%)	51 ms (-13.79% 🔽)	61 ms
thirdweb/react (minimal + tree-shaking)	16.49 KB (+0.09% 🔺)	330 ms (+0.09% 🔺)	416 ms (+16.44% 🔺)	746 ms

gregfromstl · 2024-05-13T19:29:25Z

/release-pr

Signed-off-by: greg <gregfromstl@gmail.com>

gregfromstl · 2024-05-15T00:52:00Z

/release-pr

.changeset/eight-planes-design.md

joaquim-verges · 2024-05-15T09:20:21Z

.changeset/eight-planes-design.md

+Requests the wallet to show the status of a given bundle ID.
+
+```ts
+await showCallsStatus({ wallet, bundleId });


does this actually work? it opens the wallet with the current status?

It works if the wallet supports 5792. I'm honestly not a big fan of it since it makes app developers more reliant on the wallet, but its in the spec so I included it.

packages/thirdweb/src/exports/wallets.ts

packages/thirdweb/src/utils/encoding/hex.ts

packages/thirdweb/src/wallets/eip5792/get-calls-status.ts

packages/thirdweb/src/wallets/in-app/core/lib/in-app-wallet-calls.ts

joaquim-verges · 2024-05-15T09:36:45Z

packages/thirdweb/src/wallets/in-app/core/lib/in-app-wallet-calls.ts

+} from "../../../eip5792/types.js";
+import type { Account, Wallet } from "../../../interfaces/wallet.js";
+
+const bundlesToTransactions = new Map<string, Hex[]>();


this map could get huge in a long running app. would use a bounded map here or a LRU

joaquim-verges · 2024-05-15T09:41:12Z

packages/thirdweb/src/wallets/in-app/core/lib/in-app-wallet-calls.ts

+/**
+ * @internal
+ */
+export async function inAppWalletSendCalls(args: {


having the wallet.sendCalls in the interface would def make it much cleaner here. separate implementation for inapp vs smart. this function does 2 jobs implicitely here (smart + inapp)

Would it be better to separate it anyway? They were originally separate but I combined them for reuse.

packages/thirdweb/src/wallets/in-app/core/wallet/index.ts

gregfromstl · 2024-05-15T18:56:05Z

/release-pr

packages/thirdweb/src/exports/wallets/eip5792.ts

packages/thirdweb/src/utils/uuid.ts

…nto greg/cnct-1136

gregfromstl · 2024-05-15T23:26:52Z

/release-pr

gregfromstl · 2024-05-16T00:39:22Z

/release-pr

gregfromstl added 9 commits May 10, 2024 22:59

fix: adds @types/react dependencies

6ce4837

feat(eip5792): getCapabilities

c9f8bad

feat(eip5792): sendCalls

0c2eabd

feat(eip5792): showCallsStatus

6b8c48e

feat(eip5792): getCallsStatus

06ded25

feat(eip5792): exports

c2a7ab4

test(wallets/eip5792)

docs(eip5792): sendCalls docs

70d29d5

docs(wallets/eip5792)

fix: smart wallet types

d8ee3df

changset

fcdb68b

fix(wallets): smart wallet options type

19b1171

gregfromstl added 2 commits May 11, 2024 15:19

docs: improves changeset

81b905a

feat(wallets): export WalletCall type

94397b2

gregfromstl added the DO NOT MERGE not ready to be merged yet label May 12, 2024

gregfromstl added 3 commits May 12, 2024 14:58

docs(wallets/eip5792): add @throws decorator

a8e7f11

refactor(send-calls): use prepared transactions as inputs

16d38a2

Merge branch 'main' into greg/cnct-1136

c457550

gregfromstl removed the DO NOT MERGE not ready to be merged yet label May 13, 2024

gregfromstl added 4 commits May 13, 2024 12:49

nit: stray logs

267f785

fix(get-capabilities): coinbase extension error catching

1699608

Merge branch 'main' into greg/cnct-1136

28ac838

Signed-off-by: greg <gregfromstl@gmail.com>

Merge branch 'main' into greg/cnct-1136

1e44936

gregfromstl requested review from jnsdls and joaquim-verges May 13, 2024 23:32

Merge branch 'main' into greg/cnct-1136

f628700

Merge branch 'main' into greg/cnct-1136

261ba7d

joaquim-verges requested changes May 15, 2024

View reviewed changes

gregfromstl added 2 commits May 15, 2024 09:28

Merge branch 'main' into greg/cnct-1136

e69ab5d

refactor(eip5792): requested changes

826f436

gregfromstl added 3 commits May 15, 2024 12:37

chore: better error

4f9371f

chore: fix tests

f9460cd

Merge branch 'main' into greg/cnct-1136

1159f45

joaquim-verges reviewed May 15, 2024

View reviewed changes

packages/thirdweb/src/exports/wallets/eip5792.ts Outdated Show resolved Hide resolved

packages/thirdweb/src/utils/uuid.ts Outdated Show resolved Hide resolved

gregfromstl added 4 commits May 15, 2024 16:20

fix coinbase sdk error

a65ad8e

Merge branch 'greg/cnct-1136' of https://github.com/thirdweb-dev/js i…

038e527

…nto greg/cnct-1136

fix: coinbase show calls status support

a0b62b9

Merge branch 'main' into greg/cnct-1136

16aabed

gregfromstl added 3 commits May 15, 2024 16:47

chore: remove showCallsStatus from public api

c6440a3

fix(coinbaseSDKWalletSendCalls): await for error

393dc43

fix(uuid): rename randomBytes32

7346b9a

joaquim-verges approved these changes May 16, 2024

View reviewed changes

Merge branch 'main' into greg/cnct-1136

b80aaca

gregfromstl added this pull request to the merge queue May 16, 2024

Merged via the queue into main with commit 726618b May 16, 2024
15 checks passed

gregfromstl deleted the greg/cnct-1136 branch May 16, 2024 18:58

jnsdls mentioned this pull request May 16, 2024

Version Packages #3044

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-5792 Support #3001

EIP-5792 Support #3001

gregfromstl commented May 11, 2024 •

edited by pr-codex bot

linear bot commented May 11, 2024

changeset-bot bot commented May 11, 2024 •

edited

codspeed-hq bot commented May 11, 2024 •

edited

codecov bot commented May 11, 2024 •

edited

github-actions bot commented May 11, 2024 •

edited

gregfromstl commented May 13, 2024

gregfromstl commented May 15, 2024

joaquim-verges May 15, 2024

gregfromstl May 15, 2024

joaquim-verges May 15, 2024

joaquim-verges May 15, 2024

gregfromstl May 15, 2024

gregfromstl commented May 15, 2024

gregfromstl commented May 15, 2024

gregfromstl commented May 16, 2024

EIP-5792 Support #3001

EIP-5792 Support #3001

Conversation

gregfromstl commented May 11, 2024 • edited by pr-codex bot

PR-Codex overview

Detailed summary

linear bot commented May 11, 2024

changeset-bot bot commented May 11, 2024 • edited

🦋 Changeset detected

codspeed-hq bot commented May 11, 2024 • edited

CodSpeed Performance Report

Merging #3001 will not alter performance

Summary

codecov bot commented May 11, 2024 • edited

Codecov Report

github-actions bot commented May 11, 2024 • edited

size-limit report 📦

gregfromstl commented May 13, 2024

gregfromstl commented May 15, 2024

joaquim-verges May 15, 2024

Choose a reason for hiding this comment

gregfromstl May 15, 2024

Choose a reason for hiding this comment

joaquim-verges May 15, 2024

Choose a reason for hiding this comment

joaquim-verges May 15, 2024

Choose a reason for hiding this comment

gregfromstl May 15, 2024

Choose a reason for hiding this comment

gregfromstl commented May 15, 2024

gregfromstl commented May 15, 2024

gregfromstl commented May 16, 2024

gregfromstl commented May 11, 2024 •

edited by pr-codex bot

changeset-bot bot commented May 11, 2024 •

edited

codspeed-hq bot commented May 11, 2024 •

edited

codecov bot commented May 11, 2024 •

edited

github-actions bot commented May 11, 2024 •

edited