Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core Wallet Extension Support #3018

Merged
merged 5 commits into from
May 14, 2024
Merged

Add Core Wallet Extension Support #3018

merged 5 commits into from
May 14, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 13, 2024

Fixes #3008


PR-Codex overview

This PR adds support for the Core wallet extension. It includes the Core wallet extension in the supported wallets list, adds wallet info and image, and updates the extra-wallets configuration.

Detailed summary

  • Added support for the Core wallet extension
  • Included Core wallet extension in supported wallets list
  • Added wallet info and image for Core extension
  • Updated extra-wallets configuration with Core wallet details

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet/io.ozonewallet/image.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested a review from jnsdls as a code owner May 13, 2024 21:24
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: f7a529f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Minor
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 13, 2024

CodSpeed Performance Report

Merging #3018 will degrade performances by 12.03%

Comparing greg/core-wallet (f7a529f) with main (90bb118)

Summary

❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main greg/core-wallet Change
keccakId 7.2 ms 8.1 ms -12.03%

Copy link
Contributor

github-actions bot commented May 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.11 KB (0%) 783 ms (0%) 3.2 s (+35.16% 🔺) 4 s
thirdweb (cjs) 87.96 KB (0%) 1.8 s (0%) 7.5 s (+0.49% 🔺) 9.3 s
thirdweb (minimal + tree-shaking) 4.73 KB (0%) 95 ms (0%) 184 ms (-25.01% 🔽) 279 ms
thirdweb/chains (tree-shaking) 400 B (0%) 10 ms (0%) 115 ms (+69.94% 🔺) 125 ms
thirdweb/react (minimal + tree-shaking) 16.42 KB (0%) 329 ms (0%) 449 ms (-2.63% 🔽) 778 ms

@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (90bb118) to head (f7a529f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   62.43%   62.43%           
=======================================
  Files         751      751           
  Lines       52167    52167           
  Branches     2968     2971    +3     
=======================================
+ Hits        32570    32571    +1     
+ Misses      19096    19095    -1     
  Partials      501      501           
Flag Coverage Δ *Carryforward flag
legacy_packages 54.02% <ø> (ø) Carriedforward from 716e24c
packages 64.43% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@joaquim-verges joaquim-verges added this pull request to the merge queue May 14, 2024
@gregfromstl gregfromstl removed this pull request from the merge queue due to a manual request May 14, 2024
@gregfromstl gregfromstl added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 5083464 May 14, 2024
12 of 14 checks passed
@gregfromstl gregfromstl deleted the greg/core-wallet branch May 14, 2024 20:36
@jnsdls jnsdls mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect with Core Wallet
2 participants