Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSC mainnet and testnet #3024

Merged
merged 2 commits into from
May 14, 2024
Merged

Add BSC mainnet and testnet #3024

merged 2 commits into from
May 14, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented May 14, 2024

PR-Codex overview

This PR adds support for BSC mainnet and testnet in the thirdweb package.

Detailed summary

  • Added bsc and bscTestnet chain definitions in chains.ts
  • Defined bsc chain with details for BNB Smart Chain Mainnet
  • Defined bscTestnet chain with details for BNB Smart Chain Testnet

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 94d2653

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 14, 2024

CodSpeed Performance Report

Merging #3024 will not alter performance

Comparing kien/add-bsc-chains (94d2653) with main (145ff48)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.07 KB (0%) 782 ms (0%) 4 s (+21.7% 🔺) 4.7 s
thirdweb (cjs) 87.85 KB (0%) 1.8 s (0%) 7.2 s (-3.45% 🔽) 9 s
thirdweb (minimal + tree-shaking) 4.71 KB (0%) 95 ms (0%) 264 ms (+15.94% 🔺) 359 ms
thirdweb/chains (tree-shaking) 400 B (0%) 10 ms (0%) 98 ms (+75.79% 🔺) 108 ms
thirdweb/react (minimal + tree-shaking) 16.38 KB (0%) 328 ms (0%) 544 ms (-43.8% 🔽) 872 ms

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.39%. Comparing base (08855f3) to head (94d2653).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
+ Coverage   62.37%   62.39%   +0.02%     
==========================================
  Files         749      751       +2     
  Lines       52117    52151      +34     
  Branches     2968     2971       +3     
==========================================
+ Hits        32506    32541      +35     
+ Misses      19110    19109       -1     
  Partials      501      501              
Flag Coverage Δ *Carryforward flag
legacy_packages 54.02% <ø> (ø) Carriedforward from 08855f3
packages 64.38% <100.00%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...irdweb/src/chains/chain-definitions/bsc-testnet.ts 100.00% <100.00%> (ø)
...kages/thirdweb/src/chains/chain-definitions/bsc.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kien-ngo
Copy link
Contributor Author

Damn looks like I hit the size limit. @jnsdls any chance we can increase the "floor" for this one?

@jnsdls
Copy link
Member

jnsdls commented May 14, 2024

Damn looks like I hit the size limit. @jnsdls any chance we can increase the "floor" for this one?

its not your PR we hit it before already, we'll need to look at it separately :)

@jnsdls jnsdls added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit eb29adf May 14, 2024
14 of 15 checks passed
@jnsdls jnsdls deleted the kien/add-bsc-chains branch May 14, 2024 15:35
@jnsdls jnsdls mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants