Clean up code #1673
Open
Clean up code #1673
+462
−494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
2 times, most recently
from
e06cf29
to
1041400
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JasonGrace2282
commented
May 4, 2024
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
10 times, most recently
from
aa66f95
to
4d6968b
Compare
4 tasks
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
2 times, most recently
from
18cd4da
to
ab87383
Compare
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
from
ab87383
to
e63f397
Compare
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
8 times, most recently
from
6dd24d1
to
5326564
Compare
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
3 times, most recently
from
67a76df
to
cdfe75f
Compare
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
from
cdfe75f
to
2c5956a
Compare
JasonGrace2282
force-pushed
the
precommit-lint-project
branch
from
2c5956a
to
1f30d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these were automatically fixed by running pre-commit (#1659 ).
Note that most of these should be pretty safe, as
ruffwas run without the--unsafe-fixesflag, andruffhas been designed around not modifying the resulting runtime code so most of it should run the same99% of changes fall into one of the 3 categories;
"...".format(...)tof"..."EDIT: I removed changes from all vendor files to reduce the diff (it went from a 3,000 character diff to a 500 character diff). If the maintainers of Ion want vendor files to be fixed, I can make another PR for that.