Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bus.html #1685

Closed
wants to merge 1 commit into from
Closed

Update bus.html #1685

wants to merge 1 commit into from

Conversation

DhanvinG
Copy link

Proposed changes

Changed:
.bus-announcement-container { position: absolute; top: 55%; right: 6%; width: 50%; padding: 20px !important; font-size: 30px;
To:

.bus-announcement-container { position: absolute; top: 85%; right: 3%; width: 25%; padding: 20px !important; font-size: 20px;

Changed:

#morning .bus-announcement-container { top: 50%; right: 3%; width: 27%; }

To:

#morning .bus-announcement-container { top: 80%; right: 3%; width: 25%; }

Brief description of rationale

I reduced the font size, made the assignment buttons smaller, and moved the location of the assignment buttons from the center of the page toward the bottom so it wouldn't interfere with the bus images to the left.

@DhanvinG DhanvinG requested a review from a team as a code owner May 17, 2024 21:18
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this issue. Comments: first, your diff is too big. Only change the lines that you wrote in this PR. It looks there was an indentation or other formatting change applied to the whole file. Also, make sure to edit your commit to pass CI. Finally, it would be helpful for you to post a before and after image of what the signage bus page looks like.

@DhanvinG DhanvinG closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants