Add Extension<NonCloneType> debug_handler ui test #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/debug-handler-extension-not-clone
branch
from
06b8d45
to
9cc9c7d
Compare
yanns
approved these changes
May 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Logan Nielsen <loganbn@amazon.com>
jplatte
force-pushed
the
jplatte/debug-handler-extension-not-clone
branch
from
9cc9c7d
to
758fe1b
Compare
davidpdrsn
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2294 indicates that the error message for
T: Cloneconstraint onExtension<T>'sFromRequestPartsimpl being unmet is bad even with#[debug_handler]. I decided to check and found that's false.Solution
Add a test to make sure we don't regress.
Closes #2294.
Supersedes #2301.