Update some docs.rs references to /latest/ #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users search Google for certain terms, like [tokio delay], they wind up on outdated docs for tokio 0.1: https://docs.rs/tokio/0.1/tokio/timer/struct.Delay.html. On the docs.rs team we're working on improving things so users are more likely to find the latest docs on Google. It looks like certain old blog posts on tokio.rs are causing these tokio 0.1 doc URLs to rank highly, so I'd like to bump them to use the new /latest/ format.
Darksonn
reviewed
Jan 20, 2023
Comment on lines
-120
to
+122
| [delay]: https://docs.rs/tokio/0.1/tokio/timer/struct.Delay.html | ||
| [timeout]: https://docs.rs/tokio/0.1/tokio/timer/struct.Timeout.html | ||
| [interval]: https://docs.rs/tokio/0.1/tokio/timer/struct.Interval.html | ||
| [delay]: https://docs.rs/tokio/latest/tokio/timer/struct.Delay.html | ||
| [timeout]: https://docs.rs/tokio/latest/tokio/timer/struct.Timeout.html | ||
| [interval]: https://docs.rs/tokio/latest/tokio/timer/struct.Interval.html |
There was a problem hiding this comment.
This breaks the links. There's no timer module in the latest Tokio release, and the blog posts are about the 0.1 version specifically. If possible, I would prefer to add rel="nofollow" to the links instead. You might need to use html tags in the markdown to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users search Google for certain terms, like [tokio delay], they wind up on outdated docs for tokio 0.1:
https://docs.rs/tokio/0.1/tokio/timer/struct.Delay.html.
On the docs.rs team we're working on improving things so users are more likely to find the latest docs on Google. It looks like certain old blog posts on tokio.rs are causing these tokio 0.1 doc URLs to rank highly, so I'd like to bump them to use the new /latest/ format.