added dark mode support #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancellation Tokens should be used to notify task to shut down instead of broadcast channels closes tokio-rs#694
|
How do I get my browser to switch to dark mode? |
|
@Darksonn If you "turn on" dark theme on your device, then website will also switch to dark mode |
|
for example, on macOS you can use highlighted option in image:
|
|
Looks nice on my machine, at least! |
|
@hawkw also checkout docs and code snippets |
|
Sure, this sounds good to me. I would be happy to merge this. Did you have any further changes you wanted to get in before I do so? |
|
@Darksonn let me add a button to toggle theme, then we can merge it |
|
Hey @Darksonn, You can review and merge this PR now if everything looks good |
|
I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I'm excited to share this PR for adding dark theme support. Please visit the preview, I would really appreciate your feedback and suggestions.
You can also suggest some better colors for the dark theme.
I'd also like to know if there are any UI elements where the dark theme changes have not been applied or any other feedback, I'm all ears.
Thank you so much for taking the time to review my PR and provide your insights. I look forward to hearing your thoughts!
Pending actions on this PR: