Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drawFavicon to be compatible with Chrome #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nzh
Copy link

@nzh nzh commented Oct 31, 2018

This immediately calls the onload function after it is defined, to ensure that changes are picked up.

@adrianbj
Copy link

Great PR - fixes the Chrome issue: #96

but you have a typo: uload instead of onload

@nzh
Copy link
Author

nzh commented Feb 1, 2019

fixed

@tommoor
Copy link
Owner

tommoor commented Feb 3, 2019

👋 I don't understand what this achieves, calling the onload before the src is defined. Could one of you speak to the solution?

@adrianbj
Copy link

adrianbj commented Feb 3, 2019

@tommoor - I honestly haven't looked into why this works, but the key thing in my setup that causes the problem with Chrome seems to be the presence of:

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

Chrome (on MacOS) is actually using this icon instead of the standard favicon.ico or any of the transparent png versions created by https://realfavicongenerator.net/ or one of those other services. It's actually quiet annoying because the apple icon isn't transparent. If I remove the link to the apple icon tinycon works without this fix, but if I want the apple icon, this fix works.

@brenc
Copy link

brenc commented Apr 11, 2020

Tinycon broke for us as well and this PR fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants