Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename attribute_value to unquoted_attribute_value etc #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Mar 5, 2024

this makes my life easier when using this parser in an AST transformer

the problem is that currently, attribute_value has 2 meanings:

  • attribute_value
  • quoted_attribute_value
    • singlequote, attribute_value, singlequote
    • doublequote, attribute_value, doublequote

i want to process only the parent nodes attribute_value and quoted_attribute_value
and ignore the child nodes: singlequote, doublequote, attribute_value

but currently, both parent and child nodes have the same node.kind_id

i propose to change this to

  • doublequoted_attribute_value
  • singlequoted_attribute_value
  • unquoted_attribute_value

similar to #89

maybe

group the three attribute value types under one attribute_value

  • attribute_value
    • doublequoted_attribute_value
    • singlequoted_attribute_value
    • unquoted_attribute_value

fixme

noval= bool is parsed as one attribute
when it should be parsed as two attributes

fix: disallow whitespace between nodes

<hr doublequoted="val" singlequoted='val' unquoted=val noval= bool>

@milahu milahu force-pushed the rename-attribute_value-to-unquoted_attribute_value-etc branch from 691d4dd to 737162e Compare March 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant