Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude body req for GET/HEAD according to fetch api #1050

Closed
wants to merge 2 commits into from
Closed

Exclude body req for GET/HEAD according to fetch api #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f08a1b
update: exclude body req for GET/HEAD according to fetch api
predam Apr 21, 2024
ab0798a
update: add next
predam Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/hono/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ function convertToStandardRequest(req: HonoRequest): Request {
headers[key] = value;
}

// https://developer.mozilla.org/en-US/docs/Web/API/fetch#body
const includeBody = ["GET", "HEAD"].includes(req.raw.method);

return new Request(req.raw.url, {
method: req.raw.method,
headers,
body: req.raw.body,
body: includeBody ? req.raw.body : undefined,
// @ts-ignore
duplex: "half",
});
Expand Down
5 changes: 4 additions & 1 deletion packages/nextjs/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,15 @@ async function convertToStandardRequest(nextReq: NextApiRequest): Promise<Reques
headers.set(key, value as string);
});

// https://developer.mozilla.org/en-US/docs/Web/API/fetch#body
const includeBody = !!method && ["GET", "HEAD"].includes(method);

// Create a new Request object (hardcode the url because it doesn't really matter what it is)
const webReq = new Request("https://next.js/api/trigger", {
headers,
method,
// @ts-ignore
body: nextReq,
body: includeBody ? nextReq : undefined,
duplex: "half",
});

Expand Down