v3: Refactor attempt creation to be worker requested #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericallam
commented
Apr 30, 2024
ericallam
commented
- The "worker" side now is responsible for requesting a new attempt
- Currently this is only implemented on the "dev" side
- Moves the visibility queue outside of redis and into a graphile job, which we are now using to fail runs that are in progress and hit the visibility timeout (unless the run is pending)
- Better handle cancelling runs when dev reconnects to a different web server instance
- This should allow prod workers to retry without checkpointing and without going back into the queue
🦋 Changeset detectedLatest commit: 2d30f86 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericallam
force-pushed
the
v3/worker-attempt-creation
branch
from
c822c89
to
1bba5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.