Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New filtered dropdown and run filters #1089

Merged
merged 75 commits into from May 7, 2024
Merged

New filtered dropdown and run filters #1089

merged 75 commits into from May 7, 2024

Conversation

matt-aitken
Copy link
Member

@matt-aitken matt-aitken commented May 7, 2024 •
edited

  • Added a new menu that supports filtering and keyboard shortcuts. Updated the runs page to use the new filters. New on
    • New org page
    • New project page
    • New/edit schedule panel
    • Feedback panel
CleanShot.2024-05-07.at.18.15.03.mp4

@matt-aitken
Extract out useFilterTasks
ae93d97
@matt-aitken
WIP on Combobox
f0a9b2e
@matt-aitken
Revert "WIP on Combobox"
afc2050 
This reverts commit f0a9b2e.
@matt-aitken
Added ariakit
2954fea
@matt-aitken
Started adding a Listbox component
11a4ea2
@matt-aitken
Listbox WIP
9f4fb0c
@matt-aitken
Merge remote-tracking branch 'origin/main' into multi-filterable-comb…
cf7de6e 
…oboxes
@matt-aitken
More WIP on the list box
979d6d5
@matt-aitken
More work on the Listbox
cf217b8
@matt-aitken
WIP on filterable Listbox using headless… but it’s going to be a nigh…
17c4a7a 
…tmare to make it good. Wrong approach
@matt-aitken
WIP using Ariakit
4a991a5
@matt-aitken
Multiple selection working
bce012c
@matt-aitken
WIP in reworking it so search is built in and it’s easier to use
49fea37
@matt-aitken
Nicer API for listbox
161243e
@matt-aitken
Allow sections to be rendered with filtering
847244f
@matt-aitken
More progress on the styling of the menu
c0c1655
@matt-aitken
The empty state
1ae060c
@matt-aitken
Removed focus outline
f9933d4
@matt-aitken
Allow filtering based on the section title
a85385b
@matt-aitken
Render the shortcut correctly
a8a2bc6
@matt-aitken
Allow passing static children to Select and render a separator if a s…
a338950 
…ection has no title
@matt-aitken
Static example and added subtle focus
62050e7
@matt-aitken
Allow static data with no items array passed in
39125bf
@matt-aitken
Allow shortcuts on select items
9a7cf08
@matt-aitken
Only how heading if true
68f8356
@matt-aitken
Tooltip for keyboard shortcut
63a1580
@matt-aitken
useShortcutKeys fixes
a123433 
- Can be passed an undefined definition (so we render the same number of hooks always).
- Fix for enabledOnInputElements not being used…
@matt-aitken
Shortcut keys working with lists
567f10c
@matt-aitken
Don’t render shortcut numbers higher than 0
2c7da19
@matt-aitken
More improvements
3ab7140
@matt-aitken
Added filter page to storybook
214475b
@matt-aitken
Added other variants
98c544a
@matt-aitken
Renamed Select file to OldSelect, implemented Feedback form
d6007d7
@matt-aitken
Added placeholder support
2208168
@matt-aitken
Added an optional dropdown icon (defaults to a chevron down)
a4657d0
@matt-aitken
Feedback new Select
85ec09b
@matt-aitken
Feedback just use static items
99d9eac
@matt-aitken
New project page
e224f32
@matt-aitken
Renamed storybook pages
ce6d752
@matt-aitken
Lots of progress on the new run filters
0d98988
@matt-aitken
Added new tasks filters
5e7d659
@matt-aitken
Show the applied filters
a7d9e8d
@matt-aitken
Added period filtering
b4e4449
@matt-aitken
Fix for escape resetting the period value to the previous value when …
a00cb5e 
…escape is pressed
@matt-aitken
Show the Clear button sooner
49f87a2
@matt-aitken
Removed unused code
fd0d6b2
@matt-aitken
Reworked useSearchParams so multiple values can be set at once…
5b50bde
@matt-aitken
Renamed file: OldSelect -> SImpleSelect
d5effd9
@matt-aitken
Fix for new Select not working in forms because props weren’t being p…
8eed330 
…assed through
@matt-aitken
New Select on the schedules page
38b2f72
@matt-aitken
Better layout when there are lots of run filters
52c4bf8
@matt-aitken
Many style improvements to run filters
ed74688
@matt-aitken
Status filter allows you to select as well
4bb8388
@matt-aitken
Rolled out the menus for the other files
b2f2b99
@matt-aitken
Minor improvements to schedule page and page padding
55ab0ef
@matt-aitken
Merge remote-tracking branch 'origin/main' into multi-filterable-comb…
4faa4a7 
…oboxes

# Conflicts:
#	pnpm-lock.yaml
@matt-aitken
Latest lockfile
e637882
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: e637882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken matt-aitken merged commit 7d6430d into main May 7, 2024
2 checks passed
@matt-aitken matt-aitken deleted the multi-filterable-comboboxes branch May 7, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matt-aitken