Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Graphile auto-cleanup and auto-endpoint disabling #1103

Merged
merged 3 commits into from
May 15, 2024
Merged

v2: Graphile auto-cleanup and auto-endpoint disabling #1103

merged 3 commits into from
May 15, 2024

Conversation

ericallam
Copy link
Member

  • Failed graphile jobs are no longer saved and cleaned up 7 days later, instead they are automatically deleted by not throwing in the run task
  • Auto disable endpoints that have more than a day of failed indexes in a row
  • No longer schedule webhooks to be delivered if an endpoint is disabled

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2024 •
edited

⚠️ No Changeset found

Latest commit: af5cbbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ericallam
ericallam commented May 15, 2024
View reviewed changes
Copy link
Member Author

@ericallam ericallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericallam ericallam merged commit 2496917 into main May 15, 2024
2 checks passed
@ericallam ericallam deleted the v2/auto-graphile-jobs-cleanup branch May 15, 2024 20:15
jacobparis pushed a commit to jacobparis/trigger.dev that referenced this pull request May 15, 2024
@ericallam @jacobparis
v2: Graphile auto-cleanup and auto-endpoint disabling (triggerdotdev#…
9c54c75 
…1103)

* Auto-cleanup failed graphile jobs instead of keeping them around

* Disable endpoint after a period of sequential indexing failures

* Remove log
jacobparis pushed a commit to jacobparis/trigger.dev that referenced this pull request May 21, 2024
@ericallam @jacobparis
v2: Graphile auto-cleanup and auto-endpoint disabling (triggerdotdev#…
e24f740 
…1103)

* Auto-cleanup failed graphile jobs instead of keeping them around

* Disable endpoint after a period of sequential indexing failures

* Remove log
jacobparis pushed a commit to jacobparis/trigger.dev that referenced this pull request May 21, 2024
@ericallam @jacobparis
v2: Graphile auto-cleanup and auto-endpoint disabling (triggerdotdev#…
3093610 
…1103)

* Auto-cleanup failed graphile jobs instead of keeping them around

* Disable endpoint after a period of sequential indexing failures

* Remove log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ericallam