Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info about environments added to the alerts page and alerts modal #1107

Merged
merged 1 commit into from
May 17, 2024

Conversation

samejr
Copy link
Member

@samejr samejr commented May 17, 2024

Alerts table

  • Added environments labels
  • Improved the icons for enabled/disabled

Alerts modal

  • Added Environments section with default selected and disabled options
  • Added a tooltip to explain when you receive alerts
  • Made the copy a bit friendlier and more obvious

CleanShot 2024-05-17 at 12 48 26@2x

CleanShot 2024-05-17 at 12 50 19@2x

CleanShot 2024-05-17 at 13 44 07

@samejr samejr requested a review from matt-aitken May 17, 2024 12:46
Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: f947eae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam
Copy link
Member

I think we shouldn't have the environment options there until we actually implement those. It will make the form seem broken.

@ericallam ericallam merged commit 6fecf2d into main May 17, 2024
2 checks passed
@ericallam ericallam deleted the v3/alerts-environment-messaging branch May 17, 2024 13:22
jacobparis pushed a commit to jacobparis/trigger.dev that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants