Add state and nonce verification in OIDC #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #339
Depends on #343
Add state and nonce verification and integration test in OIDC.
Implementation details
State
Ref: https://developers.google.com/identity/openid-connect/openid-connect#server-flow
Correct implementation of OIDC:
OidcCookie
)state
)Nonce
Ref: https://openid.net/specs/openid-connect-core-1_0-17_orig.html#NonceNotes
Implemented by this PR using
nonce
,hashNonce()
andOidcCookie
.Release notes
( ) Release notes are required, with the following suggested text:
*