-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for case insensitive name cache in BigQuery #21988
Conversation
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
@@ -113,9 +116,19 @@ public BigQueryClient( | |||
.expireAfterWrite(metadataCacheTtl.toMillis(), MILLISECONDS) | |||
.shareNothingWhenDisabled() | |||
.build(CacheLoader.from(this::listDatasetIdsFromBigQuery)); | |||
this.remoteDatasetCaseInsentiveCache = buildCache(caseInsensitiveNameMatchingCacheTtl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need two separate caches if they have same ttl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean merging remoteDatasetCaseInsentiveCache
& remoteDatasetIdCache
into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remoteDatasetCaseInsentiveCache & remoteTableCaseInsentiveCache
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Outdated
Show resolved
Hide resolved
e8e1c83
to
2998aba
Compare
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryClient.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java
Show resolved
Hide resolved
d9e89b7
to
48b04c4
Compare
Co-authored-by: regadas <oss@regadas.email>
Description
Supersedes #19624
Fixes #10740
Test on a schema with 180 tables:
Release notes
(x) Release notes are required, with the following suggested text: