Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Snowflake Iceberg catalog docs #22001

Merged

Conversation

mayankvadariya
Copy link
Contributor

Description

Document Snowflake Iceberg catalog limitations

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 16, 2024
@github-actions github-actions bot added the docs label May 16, 2024
@mayankvadariya mayankvadariya self-assigned this May 16, 2024
@mayankvadariya mayankvadariya force-pushed the mayank/update-snowflake-catalog-doc branch from 3ca82e8 to c57d65d Compare May 16, 2024 19:16
@mayankvadariya mayankvadariya force-pushed the mayank/update-snowflake-catalog-doc branch from c57d65d to 3ffb643 Compare May 17, 2024 14:30
@mosabua mosabua force-pushed the mayank/update-snowflake-catalog-doc branch 2 times, most recently from 08f4c43 to 79595ab Compare May 21, 2024 22:08
@mosabua mosabua changed the title Document Snowflake Iceberg catalog limitations Improve Snowflake Iceberg catalog docs May 21, 2024
@mosabua
Copy link
Member

mosabua commented May 21, 2024

Discussed this all a bit more with @mayankvadariya and updated together.

Copy link
Contributor Author

@mayankvadariya mayankvadariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@@ -577,7 +578,6 @@ The Nessie catalog does not support [view management](sql-view-management) or
[materialized view management](sql-materialized-view-management).

(iceberg-snowflake-catalog)=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ... these empty lines are redundant and we want to remove them

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@mosabua mosabua force-pushed the mayank/update-snowflake-catalog-doc branch from 79595ab to de1f2c4 Compare May 22, 2024 23:25
@mosabua mosabua merged commit b6937bb into trinodb:master May 22, 2024
3 checks passed
@github-actions github-actions bot added this to the 449 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants