feat(prisma): enable prisma generator support for ESM

[vangie]

Information

Type	Breaking change
Feature	No

---

Todos

• Tests
• Coverage
• Example
• Documentation

[Romakita]

it's preferable to add extension explicitly no ?

[vangie]

#!/usr/bin/env node --import extensionless/register

import "./cli/generator";

The modification above simplifies the originally committed code. However, it requires installing the 'extensionless' module in my own project. I'm not sure how to improve this further. Any suggestions?

[Romakita]

The target is to generate the code for esm without an additional plugin. So I prefer to not register a loader.

[Romakita]

Maybe trying to have the same code base to generate cjs and esm code is an error 🤔

[vangie]

Using top level yarn build import statement contains .js extension. but js files emit by prisma generator is missing the js extension.

lib/esm/.schema/index.js

export * from "./interfaces";
export * from "./models";
export * from "./services/PrismaService";
export * from "./repositories";

[vangie]

Shall I add a .js suffix to all these import statements? such as following ts file

tsed/packages/orm/prisma/src/generator/utils/generateIndex.ts

export function generateIndex(project: Project, baseDirPath: string, hasEnum: boolean) {
  const indexFile = path.resolve(baseDirPath, "index.ts");

  project.createSourceFile(indexFile, undefined, {overwrite: true}).addExportDeclarations(
    [
      {
        moduleSpecifier: "./interfaces"
      },
      hasEnum && {
        moduleSpecifier: "./enums"
      },
      {
        moduleSpecifier: "./models"
      },
      {
        moduleSpecifier: "./services/PrismaService"
      },
      {
        moduleSpecifier: "./repositories"
      }
    ].filter(Boolean) as any[]
  );
}

[Romakita]

@vangie done. I fixed all path. You can run locally the appropriate npm scripts "generate:postgres:esm"

If you see something wrong tell me :)

[Romakita]

Hello @vangie
Thanks a lot for this PR. You've missed to commit the yarn.lock file ;)

Also, the repo follow a angular commit convention and use semantic release. Can you remove emoji from your commit message please (isn't supported by semantic release).

The commit message must be:

feat(prisma): enable prisma generator support for ESM

[vangie]

Hello @vangie Thanks a lot for this PR. You've missed to commit the yarn.lock file ;)

Also, the repo follow a angular commit convention and use semantic release. Can you remove emoji from your commit message please (isn't supported by semantic release).

The commit message must be:

feat(prisma): enable prisma generator support for ESM

OK, I have amended the git msg and add the missing yarn.lock file

[Tomdrouv1]

@vangie @Romakita any update for this PR, it would be amazing to add it for the next update, I'm working on a project that I want to turn into full esm support but I can't because of schemas not generated in esm.

Thanks for the work !

[Romakita]

I think publish a code that support commonjs / esm for this plugin is complicated. I started the v8 branch (ESM only). Maybe it's more appropriate to add this PR to the v8 roadmap.

The branch is almost ready. There are small issue related to GQL and prisma module.

Another solution is to duplicate the code inside the tsed/prisma module (one for cjs and one esm) and use exports field to use the appropriate code convention.

See you

[Romakita]

@vangie I pushed some commit to unlock your dev ;)

Now you can generate the code for ESM and CJS.

• I removed extensionless. I prefer to manage extension each time it's necessary in our code.
• I removed the condition to not generate decorator when there is a recursive import, I don't now why you trying to fix that because, you have to generate decorators in any case !

See you

[Romakita]

@vangie @Tomdrouv1 The PR seems to be ready ;) can you review the changes ?

[Romakita]

🎉 This PR is included in version 7.71.0 🎉

The release is available on:

• v7.71.0
• GitHub release

Your semantic-release bot 📦🚀