Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lazy loading for data source file exports #10887

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

94ljy
Copy link

@94ljy 94ljy commented May 12, 2024

Description of change

Migration requires a file that exports dataSource.

Supports cases where dataSource is created asynchronously.

import { DataSource } from 'typeorm';

async function getDataSoruce(): Promise<DataSource> {
  const dataSource = new DataSource({
    // ...setting
  });

  return dataSource;
}

const dataSoruce = getDataSoruce();

export default dataSource; // type: Promise<DataSource>

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant