-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failure to validate pasted links #5061
Conversation
Also defaults validate to function rather than undefined
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These changes should also be backported to |
@bdbch @svenadlung ready for review when you can |
This change is essential to fix a breaking regression in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also defaults
validate
option toval => !!val
rather thanundefined
Please describe your changes
Fix failure to validate pasted links (#5060)
How did you accomplish your changes
Add code which was missing to check pasted links are valid like all others
How have you tested your changes
I have not
How can we verify your changes
Probably manually. I assume automated tests do not cover this since this regression was able to sneak into
2.2.0
Remarks
Fixes #5060
Checklist
Related issues
#5060