Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use nested iframes in VSCode custom editor #197

Merged
merged 10 commits into from
Apr 30, 2023
Merged

Conversation

seanchas116
Copy link
Member

@seanchas116 seanchas116 commented Apr 30, 2023

iframes inside VSCode webviews cause several problems: microsoft/vscode#129178

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
uimix-dashboard ✅ Ready (Inspect) Visit Preview Apr 30, 2023 6:24am
uimix-editor ✅ Ready (Inspect) Visit Preview Apr 30, 2023 6:24am
1 Ignored Deployment
Name Status Preview Updated (UTC)
macaron ⬜️ Ignored (Inspect) Apr 30, 2023 6:24am

@seanchas116 seanchas116 merged commit b389301 into main Apr 30, 2023
6 checks passed
@seanchas116 seanchas116 deleted the vscode-no-iframe branch April 30, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant