Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Link documentation - Remove 'With URL Object' section #65505

Closed
mfernandez97 opened this issue May 8, 2024 · 2 comments · Fixed by #65547
Closed

Docs: Link documentation - Remove 'With URL Object' section #65505

mfernandez97 opened this issue May 8, 2024 · 2 comments · Fixed by #65547
Labels
Documentation Related to Next.js' official documentation.

Comments

@mfernandez97
Copy link

mfernandez97 commented May 8, 2024 •
edited

What is the update you wish to see?

I would like to see the 'With URL Object' section removed.

Is there any context that might help us understand?

The app router does not support dynamic hrefs as stated here.

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/app/api-reference/components/link#with-url-object
@mfernandez97 mfernandez97 added the Documentation Related to Next.js' official documentation. label May 8, 2024
@mfernandez97 mfernandez97 changed the title Docs: Link documentation - 'With URL Object' Docs: Link documentation - Remove'With URL Object' section May 8, 2024
@mfernandez97 mfernandez97 changed the title Docs: Link documentation - Remove'With URL Object' section Docs: Link documentation - Remove 'With URL Object' section May 8, 2024
@maxhaomh maxhaomh mentioned this issue May 9, 2024
Merged
@samcx
Copy link
Member

samcx commented May 13, 2024

@mfernandez97 Can you clarify what part of that docs link explains that App Router does not support dynamic hrefs?

@mfernandez97
Copy link
Author

@samcx Apologies, I entered the wrong url, have since updated it! https://nextjs.org/docs/messages/app-dir-dynamic-href states:

The "Dynamic href is not supported in the App Router" error happens when you try to use a dynamic href with next/link in the app directory.
The new client-side router in Next.js does not use a mapping of dynamic routes to URLs, but rather it leverages the URL directly. This means it doesn't support dynamic href use.

samcx added a commit that referenced this issue May 14, 2024
@maxhaomh @samcx
Docs: Make "With URL Obeject" only displayed in Pages docs (#65547)
add70da 
App router [does not
support](https://nextjs.org/docs/messages/app-dir-dynamic-href) dynamic
hrefs: removing it from the app router docs, and only having it in the
pages router docs.

Fixes #65505

---------

Co-authored-by: samcx <sam@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: Make "With URL Obeject" only displayed in Pages docs maxhaomh/next.js
2 participants
@mfernandez97 @samcx