Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make "With URL Obeject" only displayed in Pages docs #65547

Merged
merged 3 commits into from
May 14, 2024

Conversation

maxhaomh
Copy link
Contributor

@maxhaomh maxhaomh commented May 9, 2024

App router does not support dynamic hrefs: removing it from the app router docs, and only having it in the pages router docs.

Fixes #65505

@maxhaomh maxhaomh requested review from a team as code owners May 9, 2024 01:20
@maxhaomh maxhaomh requested review from timeyoutakeit and leerob and removed request for a team May 9, 2024 01:20
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label May 9, 2024
@ijjk
Copy link
Member

ijjk commented May 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3893449

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented May 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3893449

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@maxhaomh maxhaomh changed the title Docs: Make "Wirth URL Obeject" only displayed in Pages docs Docs: Make "With URL Obeject" only displayed in Pages docs May 9, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR! Looks good to me.

@samcx samcx enabled auto-merge (squash) May 14, 2024 17:34
@samcx samcx merged commit add70da into vercel:canary May 14, 2024
33 checks passed
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
)

App router [does not
support](https://nextjs.org/docs/messages/app-dir-dynamic-href) dynamic
hrefs: removing it from the app router docs, and only having it in the
pages router docs.

Fixes vercel#65505

---------

Co-authored-by: samcx <sam@vercel.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Link documentation - Remove 'With URL Object' section
4 participants