Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HMR with full assetPrefix URLs #65491

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
+8 −1
Open

Fix HMR with full assetPrefix URLs #65491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/next/src/server/lib/router-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,8 +650,15 @@ export async function initialize(opts: {
if (opts.dev && developmentBundler && req.url) {
const { basePath, assetPrefix } = config

// only prefix the URL with the asset prefix if it lacks a protocol
const prefix =
assetPrefix.startsWith('http://') ||
assetPrefix.startsWith('https://')
? ''
: assetPrefix || basePath

const isHMRRequest = req.url.startsWith(
ensureLeadingSlash(`${assetPrefix || basePath}/_next/webpack-hmr`)
ensureLeadingSlash(`${prefix}/_next/webpack-hmr`)
)

// only handle HMR requests if the basePath in the request
Expand Down