use prehash to avoid rehashing the key in the task cache #8174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
|
turbo-orchestrator
bot
added
owned-by: turborepo
and removed
owned-by: turborepo
labels
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arlyon
added a commit
that referenced
this pull request
May 22, 2024
### Description In this PR #8174 the library prehash is licensed using MPL2.0 (great) but without the copyleft exception. I believe that we are OK. From what I understand this prevents us from making and redistributing changes to this library under one of the MPL secondary licenses ("Secondary License" means either the GNU General Public License, Version 2.0, the GNU Lesser General Public License, Version 2.1, the GNU Affero General Public License, Version 3.0, or any later versions of those licenses). It does not exclude us from using that library in a 'larger work' that is licensed using a different (compatible) license so for the purpose of distributing a binary it is the same as MPL-2.0 ### Testing Instructions N/A
|
See my comment here: #8194 (review) I don't think this library is providing much value, and we could easily implement this ourselves, which might avoid the mess with the extra MPL license variant. |
arlyon
requested changes
Jun 3, 2024
There was a problem hiding this comment.
After a fair bit of license palava, replacing with https://app.graphite.dev/github/pr/vercel/turbo/8262/add-crate-to-calculate-prehashes
arlyon
force-pushed
the
arlyon/prehash-crate
branch
from
c6c969d
to
334f637
Compare
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jun 5, 2024
# Turbopack * vercel/turbo#8272 <!-- Donny/강동윤 - feat: Update `swc_core` to `v0.92.8` --> * vercel/turbo#8262 <!-- Alexander Lyon - add crate to calculate prehashes --> * vercel/turbo#8174 <!-- Tobias Koppers - use prehash to avoid rehashing the key in the task cache --> * vercel/turbo#7674 <!-- Alexander Lyon - [turbo trace] add ability to filter by value and occurences --> * vercel/turbo#8287 <!-- Donny/강동윤 - feat: Update `swc_core` to `v0.92.10` --> * vercel/turbo#8037 <!-- Alexander Lyon - create turbo-static for compile time graph analysis --> * vercel/turbo#8293 <!-- Will Binns-Smith - Sync Cargo.lock with Next.js --> * vercel/turbo#8239 <!-- Benjamin Woodruff - Reduce amount of code generated by ValueDebugFormat --> * vercel/turbo#8304 <!-- Benjamin Woodruff - Minor optimizations to the codegen of TaskFnInputFunction --> * vercel/turbo#8221 <!-- Donny/강동윤 - perf: Introduce `RcStr` --> ### What? I tried using `Arc<String>` in vercel/turbo#7772, but a team member suggested creating a new type so we can replace underlying implementation easily in the future. ### Why? To reduce memory usage. ### How? Closes PACK-2776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids hashing the task type multiple times, e. g. for inserting after lookup or on rehashing of the hash map
Testing Instructions